8000 MAINT: Further unify handling of unnamed ufuncs by eric-wieser · Pull Request #9400 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

MAINT: Further unify handling of unnamed ufuncs #9400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2017
Merged

MAINT: Further unify handling of unnamed ufuncs #9400

merged 1 commit into from
Jul 21, 2017
+30 −42

Conversation

eric-wieser
Copy link
Member

Follows on from gh-8876

This function needed lifting to a more visible level, so it could be used in the auxiliary ufunc files.

ufunc_get_name_cstr is a lousy name, but ufunc_get_name is already taken by the function returning PyObject*

eric-wieser
eric-wieser commented Jul 11, 2017
View reviewed changes
numpy/core/src/umath/ufunc_type_resolution.c
@@ -1342,7 +1327,7 @@ PyUFunc_DefaultLegacyInnerLoopSelector(PyUFuncObject *ufunc,
PyObject *errmsg;
int i, j;

ufunc_name = ufunc->name ? ufunc->name : "(unknown)";
Copy link
Member Author
@eric-wieser eric-wieser Jul 11, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changed to now be <unnamed ufunc>, but error messages aren't public API anyway (and we did this type of thing in gh-8876 already)

@charris
Copy link
Member
charris commented Jul 21, 2017

LGTM, does #8876 need to go in first?

@charris charris self-assigned this Jul 21, 2017
@charris charris removed their assignment Jul 21, 2017
@charris charris merged commit 9afb77a into numpy:master Jul 21, 2017
@charris
Copy link
Member
charris commented Jul 21, 2017

Thanks Eric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charris charris charris approved these changes

Assignees
No one assigned
Labels
03 - Maintenance component: numpy._core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eric-wieser @charris
0