BUG: Fixes ndarray.fill to accept maximum uint64 value #5618
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
np.ndarray.fill
to attempt to convert touint64
if its argument is a Python integer and conversion toint64
fails.np.ndarray.fill
now accepts the Python long2**64 - 1
as a value. Previously it failed because the value overflows anint64
anduint64
was not attempted. Constructing the value as auint64
manually and then passing it to fill succeeded.Fixes #5612