BUG: fix not returning out array from ufuncs with subok=False set #5242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /* If a 'subok' parameter is passed and isn't True, don't wrap */ | ||
| /* | ||
| * If a 'subok' parameter is passed and isn't True, don't wrap but put None | ||
| * into slots with out arguments |
There was a problem hiding this comment.
Umm, wrap what? Why put None into the out argument slots?
There was a problem hiding this comment.
None is the value used to indicate to return the output argument NULL is create a new return array via PyArray_Return
There was a problem hiding this comment.
OK, might add that to the comment.
6016402 to
b40e686
Compare
|
Thanks Julian. I needed a PR I could commit ;) |
charris
added a commit
that referenced
this pull request
Oct 28, 2014
BUG: fix not returning out array from ufuncs with subok=False set
juliantaylor
added a commit
that referenced
this pull request
Oct 28, 2014
BUG: fix not returning out array from ufuncs with subok=False set
|
Thanks for solving it so quickly. Just in case: Since you had milestone 1.9.1 for #5240, should it be set here as well, as a reminder to add it to that branch? |
|
I have already pushed the commit to the branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes gh-5240