8000 BUG: cannot convert invalid sequence index to tuple by seberg · Pull Request #5066 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

BUG: cannot convert invalid sequence index to tuple #5066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2014

Conversation

seberg
Copy link
Member
@seberg seberg commented Sep 11, 2014

A sequence which raises an error on item getting, should be just
handled as a single index and not a tuple nd-index.

Also fix some error handling.

closes gh-5063

Tests still missing...

@charris
Copy link
Member
charris commented Sep 11, 2014

This could use a backport. @juliantaylor Do do you want keep working with a common rebase? Cherry picks of these small fixes aren't that bad.

@juliantaylor
Copy link
Contributor

I'd like to continue it unless everybody feels its too much hassle
this simple change would already throws of other git cherry-picks of the same file and it makes it a bit easier to track whats fixed in the maintenance branch

@seberg
Copy link
Member Author
seberg commented Sep 12, 2014

Yeah, I just keep forgetting...

@charris
Copy link
Member
charris commented Sep 12, 2014

@seberg Looks like this needs the rebase then.

A sequence which raises an error on item getting, should be just
handled as a single index and not a tuple nd-index.

Also fix some error handling.

closes numpygh-5063
@seberg
Copy link
Member Author
seberg commented Sep 13, 2014

Rebased and test added.

@juliantaylor
Copy link
Contributor

thanks

juliantaylor added a commit that referenced this pull request Sep 13, 2014
BUG: cannot convert invalid sequence index to tuple
@juliantaylor juliantaylor merged commit ca39bc1 into numpy:master Sep 13, 2014
@seberg seberg deleted the index-sequence branch September 13, 2014 12:21
juliantaylor added a commit that referenced this pull request Sep 13, 2014
BUG: cannot convert invalid sequence index to tuple
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference count error from subscript operation
3 participants
0