8000 TST: add some tests of np.log for complex input. by WarrenWeckesser · Pull Request #24448 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

TST: add some tests of np.log for complex input. #24448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 5, 2024
Merged

TST: add some tests of np.log for complex input. #24448

merged 3 commits into from
Jun 5, 2024

Conversation

WarrenWeckesser
Copy link
Member

These are values where some platforms might lose precision.

[skip circle]

@WarrenWeckesser WarrenWeckesser marked this pull request as draft August 18, 2023 13:42
@mattip
Copy link
Member
mattip commented Aug 20, 2023

Thanks. The failing tests are helpful (points out where we should be blocklisting clog on musllinux, cygwin, and pyodide). I wonder if at some point we should adopt the cpython cmath tests with the extensive test cases for at least cdouble.

@WarrenWeckesser
TST: add some tests of np.log for complex input.
8b28d4f 
These are values where some platforms might lose precision.

[skip circle]
@WarrenWeckesser WarrenWeckesser marked this pull request as ready for review June 5, 2024 00:42
@WarrenWeckesser
Copy link
Member Author
WarrenWeckesser commented Jun 5, 2024 •
edited
Loading

Reviving this PR; I rebased and force pushed the original commit.

Following the example of #25092, where the complex trig functions were blocklisted for musl, I added the appropriate undefs in npy_config.h for the complex log functions.

The pyodide tests also pass now, since emscripten uses musl.

The failure of the freebsd_test job is not related to this PR: "Not enough compute credits to prioritize tasks!"

@WarrenWeckesser
Copy link
Member Author

Also block the use of the provided complex log functions on cygwin. cygwin uses newlib, and newlib's implementation of the complex log is the same naive implementation as that of musl.

@mattip mattip merged commit 009df82 into numpy:main Jun 5, 2024
67 of 68 checks passed
@mattip
Copy link
Member
mattip commented Jun 5, 2024

Thanks @WarrenWeckesser

@WarrenWeckesser WarrenWeckesser deleted the test-complex-log branch June 5, 2024 09:59
@WarrenWeckesser WarrenWeckesser mentioned this pull request Jun 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
05 - Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WarrenWeckesser @mattip
0