8000 pyproject.toml: Upgrade setuptools for Python 3.12 beta 1 by cclauss · Pull Request #23824 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

pyproject.toml: Upgrade setuptools for Python 3.12 beta 1 #23824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

pyproject.toml: Upgrade setuptools for Python 3.12 beta 1 #23824

wants to merge 2 commits into from

Conversation

cclauss
Copy link
@cclauss cclauss commented May 28, 2023

@mattip
Copy link
Member
mattip commented May 28, 2023

We deliberately pin setuptools to work around other problems with numpy.distutils. The plan for python 3.12 is to move to the meson build system, and to deprecate use of setuptools. You can try out the meson build using python3.12 -m pip install -r build_requirements.txt; python3.12 -m spin build.

@cclauss
Copy link
Author
cclauss commented May 28, 2023 •
edited
Loading

Remarkably, with this one change, I am able to successfully:
python3.12 -m pip install Cython git+https://github.com/cclauss/numpy.git@patch-1

@mattip
Copy link
Member
mattip commented May 28, 2023

Can you run tests?

@cclauss
Copy link
Author
cclauss commented May 28, 2023 •
edited
Loading

55 successful, 2 skipped, 3 failing checks

Build_Test / intel_spr_sde_test (pull_request) Failing after 37s

RuntimeError: Unrecognized setuptools command: ['editable_wheel', '--dist-dir', '/tmp/pip-wheel-11ogh7zp/.tmp-yehi2l_w']
Perhaps this is caused by editable_wheel being considered private in current versions of setuptools.

azure-pipeline numpy.numpy

azure-pipeline numpy.numpy (ComprehensiveTests Windows Python39-32bit-full)

@cclauss cclauss marked this pull request as draft May 28, 2023 08:55
@EwoutH EwoutH mentioned this pull request Jun 4, 2023
Closed
@cclauss cclauss closed this Jun 5, 2023
@cclauss cclauss deleted the patch-1 branch June 5, 2023 09:20
@cclauss
Copy link
Author
cclauss commented Jun 5, 2023

@EwoutH Perhaps you have a clearer vision about how to do this.

@rgommers
Copy link
Member
rgommers commented Jun 5, 2023

Until gh-23838 is merged, you can either use the branch from which I made that PR, or follow the instructions at https://github.com/numpy/numpy/blob/main/building_with_meson.md#pip-install.

@rgommers
Copy link
Member
rgommers commented Jun 5, 2023

Also note that 3.12.0b1 has a bug that may cause a crash in numpy, and is fixed in CPython's main branch (see gh-23766).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @mattip @rgommers
0