8000 BUG: Fix headers for universal2 builds by isuruf · Pull Request #20270 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: Fix headers for universal2 builds #20270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2021
Merged

BUG: Fix headers for universal2 builds #20270

merged 1 commit into from
Nov 1, 2021

Conversation

isuruf
Copy link
Contributor
@isuruf isuruf commented Nov 1, 2021

There were some support for universal (intel+powerpc) wheels.
This does something similar for universal2 (intel+arm) wheels

@isuruf isuruf mentioned this pull request Nov 1, 2021
Closed
@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Nov 1, 2021
charris
charris reviewed Nov 1, 2021
View reviewed changes
@charris charris merged commit ae453aa into numpy:main Nov 1, 2021
@charris
Copy link
Member
charris commented Nov 1, 2021

Thanks @isuruf .

@isuruf isuruf deleted the headers branch November 1, 2021 19:47
@charris charris mentioned this pull request Nov 3, 2021
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Nov 3, 2021
@mattip mattip mentioned this pull request Nov 5, 2021
Open
@mattip mattip mentioned this pull request Nov 23, 2021
Merged
mattip
mattip reviewed Aug 23, 2022
View reviewed changes
numpy/core/include/numpy/numpyconfig.h
#define NPY_SIZEOF_COMPLEX_LONGDOUBLE 32
#elif defined(__arm64__)
#define NPY_SIZEOF_LONGDOUBLE 8
#define NPY_SIZEOF_COMPLEX_LONGDOUBLE 16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am trying to build with the macos-provided clang and getting weird errors because of this. @isuruf Shouldn't this be 16/32?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isuruf Shouldn't this be 16/32?

No, long double is equivalent to double on macos-arm64

@mattip mattip mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charris charris charris left review comments

@mattip mattip mattip left review comments

Assignees
No one assigned
Labels
00 - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isuruf @charris @mattip
0