8000 BLD, BUG: Fix detecting aarch64 on macOS by seiko2plus · Pull Request #18001 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BLD, BUG: Fix detecting aarch64 on macOS #18001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2020
Merged

BLD, BUG: Fix detecting aarch64 on macOS #18001

merged 2 commits into from
Dec 23, 2020

Conversation

seiko2plus
Copy link
Member
@seiko2plus seiko2plus commented Dec 15, 2020 •
edited
Loading

related to #17964

TODO:

  • manually test on a wide range of compilers and platforms

@github-actions github-actions bot added the 36 - Build Build related PR label Dec 15, 2020
@seiko2plus seiko2plus mentioned this pull request Dec 15, 2020
Closed
@mattip
Copy link
Member
mattip commented Dec 15, 2020

This is OK, but I am concerned that the no-optimizations path led to a segfault. If that is the case, perhaps the detection code should raise an error earlier instead of allowing a bad build.

@charris
Copy link
Member
charris commented Dec 16, 2020

Will this need a backport?

@seiko2plus
Copy link
Member Author

@mattip,
just another bug discovered by the build log in #17964. the current patch didn't fix the issue I thought the problem is CCompilerOpt detecting the arch as it was armv7 but after a deep look in the build log I found that CCompilerOpt actually detecting CPU arch as x86_64 because Xcode toolchain adds -arch x86_64 to the compiler build options.
So I gonna need to fix CCompilerOpt::dist_info to avoid searching on command options.

@charris, yes, I think we need a backport to 1.20.

@seiko2plus seiko2plus marked this pull request as draft December 16, 2020 03:50
@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Dec 16, 2020
@charris charris added this to the 1.20.0 release milestone Dec 16, 2020
@seiko2plus seiko2plus force-pushed the fix_detect_aarch64_osx branch from 0f22ec4 to 46459b5 Compare December 16, 2020 21:20
seiko2plus
seiko2plus commented Dec 16, 2020
View reviewed changes
seiko2plus
seiko2plus commented Dec 16, 2020
View reviewed changes
h-vetinari
h-vetinari reviewed Dec 17, 2020
View reviewed changes
@seiko2plus seiko2plus force-pushed the fix_detect_aarch64_osx branch from c6434f5 to 211034f Compare December 20, 2020 03:44
@seiko2plus seiko2plus force-pushed the fix_detect_aarch64_osx branch from aeb3e46 to 3944f40 Compare December 20, 2020 19:21
@seiko2plus seiko2plus marked this pull request as ready for review December 20, 2020 19:22
@charris
Copy link
Member
charris commented Dec 23, 2020

Let's get this into 1.20.0rc2. Thanks Sayed.

@charris charris merged commit 2e5502e into numpy:master Dec 23, 2020
@charris charris mentioned this pull request Dec 23, 2020
Merged
1 task
@charris charris added 00 - Bug and removed 09 - Backport-Candidate PRs tagged should be backported labels Dec 23, 2020
@charris charris removed this from the 1.20.0 release milestone Dec 23, 2020
@seiko2plus seiko2plus mentioned this pull request Jan 4, 2021
Closed
@seiko2plus seiko2plus deleted the fix_detect_aarch64_osx branch January 9, 2021 16:51
@rgommers rgommers added the component: SIMD Issues in SIMD (fast instruction sets) code or machinery label Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-vetinari h-vetinari h-vetinari left review comments

Assignees
No one assigned
Labels
00 - Bug 36 - Build Build related PR component: SIMD Issues in SIMD (fast instruction sets) code or machinery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@seiko2plus @mattip @charris @h-vetinari @rgommers
0