ENH: Add annotations for bitwise operations #17465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Unfortunately the likes of `self: uint64` don't work with protocols. Revisit this once we add proper support for numerical precision.
eric-wieser
reviewed
Oct 7, 2020
Comment on lines
+116
to
+118
| # TODO: The likes of `uint64 | np.signedinteger` will fail as there | ||
| # is no signed integer type large enough to hold a `uint64` | ||
| # See https://github.com/numpy/numpy/issues/2524 |
There was a problem hiding this comment.
This comment seems misplaced to me, it applies to the second overload only.
There was a problem hiding this comment.
This is correct. Inserting a comment between two overloads looks visually rather bad though, hence why it is on top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds annotations for
ndarrayandgenericbitwise operations:__invert____lshift____rshift____and____or____xor__