8000 BUG, MAINT: Remove overzealous automatic RST link by Carreau · Pull Request #16807 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG, MAINT: Remove overzealous automatic RST link #16807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2020
Merged

BUG, MAINT: Remove overzealous automatic RST link #16807

merged 1 commit into from
Jul 13, 2020

Conversation

Carreau
Copy link
Contributor
@Carreau Carreau commented Jul 11, 2020

When adding links to all the NEPs, one non-rst file was taken in the
crossfire.

@Carreau
BUG, MAINT: Remove overzealous automatic RST link
c092cd1 
When adding links to all the NEPs, one non-rst file was taken in the
crossfire.
rossbar
rossbar approved these changes Jul 11, 2020
View reviewed changes
Copy link
Contributor
@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks @Carreau !

@charris
Copy link
Member
charris commented Jul 12, 2020

There are two nep-0016-* files and benchmark one doesn't conform to the template. There is something deeper wrong here. Both came in with #12174, I wonder if it was a mistake?

@charris
Copy link
Member
charris commented Jul 12, 2020

OK, the nep-0016-benchmark.py was an attachment to nep-0016-abstract-array.rst

.. literalinclude:: nep-0016-benchmark.py

See it rendered at https://numpy.org/neps/nep-0016-abstract-array.html . I suggest that we simply move the script into the main NEP

@Carreau
Copy link
Contributor Author
Carreau commented Jul 12, 2020

I don't think that has much impact. For it was just the fact that the py file was invalid syntax that make a docstring-formatting tool I'm working on choke on that.

@charris
Copy link
Member
charris commented Jul 12, 2020

I don't think that has much impact.

Just that it is confusing to have two nep-0016* files, one of which is *.py. It is easy enough to copy the benchmark code from the docs if needed.

@charris charris merged commit 92fdfbd into numpy:master Jul 13, 2020
@charris
Copy link
Member
charris commented Jul 13, 2020

Thanks @Carreau .

@Carreau Carreau deleted the no-nep-link branch March 21, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossbar rossbar rossbar approved these changes

Assignees
No one assigned
Labels
00 - Bug 03 - Maintenance 04 - Documentation component: NEP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Carreau @charris @rossbar
0