8000 ENH: Implement concatenate dtype and casting keyword arguments by seberg · Pull Request #16134 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

ENH: Implement concatenate dtype and casting keyword arguments #16134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 3, 2020
Merged

ENH: Implement concatenate dtype and casting keyword arguments #16134

merged 5 commits into from
Sep 3, 2020

Conversation

seberg
Copy link
Member
@seberg seberg commented May 1, 2020

Unfortunately, the casting was not consistent and sometimes used
force casting (axis=None) while normally same kind casting was used.
This thus deprecates the force_casting corner case, so that
casting has to be provided in the future.

Builds on top of gh-16133 (so marking it draft) and is partially motivated as by making gh-15925 an easier transition.
The deprecation should be pretty rare, since it is in the axis=None corner-case only.

@seberg seberg changed the title Concatenate dtype ENH: Implement concatenate dtype and casting keyword arguments May 1, 2020
@seberg seberg force-pushed the concatenate-dtype branch 2 times, most recently from 369cac8 to ab101e8 Compare May 1, 2020 21:53
anirudh2290
anirudh2290 reviewed May 6, 2020
View reviewed changes
@seberg seberg force-pushed the concatenate-dtype branch from ab101e8 to e4459bd Compare May 13, 2020 16:19
@seberg seberg marked this pull request as ready for review May 13, 2020 16:23
@seberg seberg removed the 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes label May 13, 2020
@seberg seberg force-pushed the concatenate-dtype branch 2 times, most recently from 596f057 to f8755f9 Compare May 19, 2020 14:14
@seberg
Copy link
Member Author
seberg commented May 19, 2020

OK, last commit should have fixed the test failure (potential use-after free of dtype, detected in debug builds), shoudl have used PyArray_DESCR(ret) instead in one place.

@seberg seberg added the 62 - Python API Changes or additions to the Python API. Mailing list should usually be notified. label May 19, 2020
anirudh2290
anirudh2290 reviewed May 20, 2020
View reviewed changes
eric-wieser
eric-wieser reviewed May 20, 2020
View reviewed changes
eric-wieser
eric-wieser reviewed May 20, 2020
View reviewed changes
eric-wieser
eric-wieser reviewed May 20, 2020
View reviewed changes
eric-wieser
eric-wieser reviewed May 20, 2020
View reviewed changes
eric-wieser
eric-wieser reviewed May 20, 2020
View reviewed changes
@mattip
Copy link
Member
mattip commented Jun 10, 2020

@seberg there is a merge conflict

@seberg seberg force-pushed the concatenate-dtype branch 2 times, most recently from f6b6d34 to 266b4af Compare June 11, 2020 02:04
@seberg
Copy link
Member Author
seberg commented Jun 12, 2020

Hmmm, not sure why the code-cov is so bad, I am not quite certain whether or not it considers the Deprecation warning tested, but I guess the problem is just the C-API code...

I found another small bug thinking about adding a few more tests for untested Errors :)...

@anirudh2290
Copy link
Member

Hmmm, not sure why the code-cov is so bad, I am not quite certain whether or not it considers the Deprecation warning tested, but I guess the problem is just the C-API code...

yep looks bad. I guess its able to correctly flag the coverage thing, but not able to point exactly what the issue is.

@seberg seberg mentioned this pull request Sep 3, 2020
Open
seberg and others added 2 commits September 2, 2020 20:11
@seberg
ENH: Implement concatenate dtype and casting keyword arguments
cfd553d 
Unfortunately, the casting was not consistent and sometimes used
force casting (axis=None) while normally same kind casting was used.
This thus deprecates the `force_casting` corner case, so that
casting has to be provided in the future.
@seberg @eric-wieser
Apply suggestions from code review
3cddaa9 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@mattip
Copy link
Member
mattip commented Sep 3, 2020

s390x is failing typing tests, with flatiter has no attr "rand". Seems unrelated.

mattip
mattip reviewed Sep 3, 2020
View reviewed changes
mattip
mattip reviewed Sep 3, 2020 8000
View reviewed changes
@charris charris mentioned this pull request Sep 3, 2020
Merged
@mattip mattip merged commit 99bcf99 into numpy:master Sep 3, 2020
@mattip
Copy link
Member
mattip commented Sep 3, 2020

Thanks @seberg

@charris charris mentioned this pull request Oct 10, 2020
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@mattip mattip mattip left review comments

@anirudh2290 anirudh2290 anirudh2290 approved these changes

Assignees
No one assigned
Labels
01 - Enhancement 07 - Deprecation 62 - Python API Changes or additions to the Python API. Mailing list should usually be notified. component: numpy._core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seberg @mattip @anirudh2290 @eric-wieser
0