8000 BLD: Add a best-effort build.log parser that looks for warnings by mattip · Pull Request #14470 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BLD: Add a best-effort build.log parser that looks for warnings #14470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

BLD: Add a best-effort build.log parser that looks for warnings #14470

wants to merge 1 commit into from

Conversation

mattip
Copy link
Member
@mattip mattip commented Sep 10, 2019

Add a parser that under "normal development" workflow (on linux, using gcc, without --show-build) will raise an error if warnings are emitted during run_tests.py

I have been bitten by this many times, where I miss the warnings since I do not by default look at the build.log. This works for me (I caused a warning to be emitted and indeed runtests.py fails.

How much further should I pursue this: adding support for clang, windows, using --show-build ?

@rgommers
Copy link
Member

Besides the XXX which I'm not sure is easy to solve (although that would be cool irrespective of build warning checks), this won't work for everyone. For one, one doesn't have to use runtests.py (I don't, preferring an inplace build). Another, the NumPy build is not warning-free right now with GCC 9.1 on Linux; every new compiler version or other compiler (e.g. Clang) introduces new warnings.

Some related things that are perhaps higher value:

  • hide the _configtest output by default. we regularly get issues about those where people see lots of errors and for example hit Ctrl-C
  • introduce a CI run that's clean with the latest GCC. we have a -Werror build somewhere, but only with old GCC (existing build matrix entry could be updated)
  • introduce a CI run that's clean on macOS with Clang (lots of warnings right now)

@mattip mattip mentioned this pull request Sep 15, 2019
Merged
@charris charris changed the title BUILD: add a best-effort build.log parser that looks for warnings BLD: Add a best-effort build.log parser that looks for warnings Sep 20, 2019
@mattip
Copy link
Member Author
mattip commented Sep 25, 2019

Closing this. It is replaced by python --runtests.py --warn-error

@mattip mattip closed this Sep 25, 2019
@mattip mattip deleted the fail-runtest-via-warnings branch December 3, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
01 - Enhancement component: build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattip @rgommers @charris
0