8000 BUG: fix compilation of 3rd party modules with Py_LIMITED_API enabled by charris · Pull Request #14056 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

BUG: fix compilation of 3rd party modules with Py_LIMITED_API enabled #14056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

charris
Copy link
Member
@charris charris commented Jul 18, 2019

Backport of #13725

There are no macros PyTuple_GET_SIZE and PyTuple_GET_ITEM available when compiling with enabled Py_LIMITED_API.

Breaking change has been made in PR #10860. Before the change these macros had been used only in NPY_TITLE_KEY macro and had not been compiled not used. After the change they have been moved to a function and now are always visible to compiler. Other projects using numpy C-API can not be compiled with Py_LIMITED_API macro enabled because of this problem.

There are no macros PyTuple_GET_SIZE and PyTuple_GET_ITEM available when compiling with enabled Py_LIMITED_API.
@charris charris added 00 - Bug 08 - Backport Used to tag backport PRs 30 - API labels Jul 18, 2019
@charris charris added this to the 1.16.5 release milestone Jul 18, 2019
@charris charris merged commit 956f44d into numpy:maintenance/1.16.x Jul 19, 2019
@charris charris deleted the backport-13725 branch July 19, 2019 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0