8000 BUG: Fix SystemError when pickling datetime64 array with pickle5 by charris · Pull Request #12844 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

BUG: Fix SystemError when pickling datetime64 array with pickle5 #12844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

charris
Copy link
Member
@charris charris commented Jan 24, 2019

Backport of #12748.

Check for error when calling the PickleBuffer constructor in ndarray.__reduce_ex__,
and fall back on the regular __reduce__ implementation for arrays which don't
support taking a buffer.

Also fix some reference leaks.

Fixes gh-12745, gh-12793

  • BUG: Fix SystemError when pickling datetime64 array with pickle5

Fixes gh-12745

  • Fix reference and error handling

  • Add a test for the fixed reference leak

  • Fix for PyPy + simplify #if condition

  • Fix comment

…py#12748)

* BUG: Fix SystemError when pickling datetime64 array with pickle5

Fixes numpygh-12745

* Fix reference and error handling

* Add a test for the fixed reference leak

* Fix for PyPy + simplify #if condition

* Fix comment
@charris charris added this to the 1.16.1 release milestone Jan 24, 2019
@charris charris merged commit 4786998 into numpy:maintenance/1.16.x Jan 24, 2019
@charris charris deleted the backport-12748 branch January 24, 2019 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0