BUG: Fix SystemError when pickling datetime64 array with pickle5 #12844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py#12748) * BUG: Fix SystemError when pickling datetime64 array with pickle5 Fixes numpygh-12745 * Fix reference and error handling * Add a test for the fixed reference leak * Fix for PyPy + simplify #if condition * Fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12748.
Check for error when calling the PickleBuffer constructor in
ndarray.__reduce_ex__,and fall back on the regular
__reduce__implementation for arrays which don'tsupport taking a buffer.
Also fix some reference leaks.
Fixes gh-12745, gh-12793
Fixes gh-12745
Fix reference and error handling
Add a test for the fixed reference leak
Fix for PyPy + simplify #if condition
Fix comment