DEV: Add basic valgrind testing support to runtest.py #12718
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not surprisingly this turns out to be pretty useless. First it is just too slow to check for memory leaks often (maybe nice to narrow down, but that is about it), and it also appears to be not super reliable. EDIT: That said, maybe if someone wants to do checks over a similar test suit (or numpy) without memchecks or to narrow down leaks. Something similar might be helpful. I just do not think it is helpful generally enough. (Leveraging sanitizers may also be something for the future.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all a big hack probably. But thought I would open anyway just in case someone was interested, so feel free to just close it, I might myself.
It does work (although i did not test all paths). If available it runs with https://github.com/seberg/pytest-valgrind which may be nice in many ways, but is also alpha and may have some small issues.
Basically adds
--valgrindwith some defaults to runtest.py. It detects the option, and then calls itself again insidevalgrind. If available it uses the pytest module I put up, although that currently swallows errors which occur already at import time.