ENH: Chain exceptions to give better error messages for invalid PEP3118 format strings #11119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where would be a good place for |
charris
reviewed
May 27, 2018
numpy/core/src/multiarray/buffer.c
Outdated
| PyErr_Format(PyExc_ValueError, | ||
| "'%s' is not a valid PEP 3118 buffer format string", buf); | ||
| PyArray_ChainExceptionsCause(exc, val, tb); |
There was a problem hiding this comment.
Looks like the prototype for PyArray_ChainExceptionsCause needs to be in an include file, it is defined in arrayobject.c.
There was a problem hiding this comment.
Which include file would you recommend? npy_compat.h?
|
We might want to reconsider the layout of the include files at some point. |
03d26f5 to
1515b7e
Compare
…18 format strings
Sample console output:
```
In [1]: from ctypes import c_wchar
In [2]: x = c_wchar * 3
In [3]: np.array(x())
---------------------------------------------------------------------------
ValueError Traceback (most recent call last)
~\Repos\numeric-python\numpy\build\testenv\Lib\site-packages\numpy\core\_internal.py in _dtype_from_pep3118(spec)
486
--> 487 dtype, align = __dtype_from_pep3118(stream, is_subdtype=False)
488 return dtype
~\Repos\numeric-python\numpy\build\testenv\Lib\site-packages\numpy\core\_internal.py in __dtype_from_pep3118(stream, is_subdtype)
558 else:
--> 559 raise ValueError("Unknown PEP 3118 data type specifier %r" % stream.s)
560
ValueError: Unknown PEP 3118 data type specifier 'u'
The above exception was the direct cause of the following exception:
ValueError Traceback (most recent call last)
<ipython-input-3-f8a17df3aa24> in <module>()
----> 1 np.array(x())
ValueError: '<u' is not a valid PEP 3118 buffer format string
```
1515b7e to
b6e03a4
Compare
|
Moved to np_compat3k.h and prefixed with |
|
Thanks Eric |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample console output: