-
-
Notifications
You must be signed in to change notification settings - Fork 11k
MAINT: remove star imports #10254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: remove star imports #10254
Conversation
This was done by looking at |
|
This commit is: $ pip install python-dewildcard==0.2 $ dewildcard
This commit adjusts whitespace only
Some globals weren't present on Python 2.7 and/or needed manual tinkering.
Okay, I'm +1 on merging as-is assuming I haven't made any mistakes. The idea is to allow static analyzers to work their magic in a future PR to remove duplicates. |
In this case I'm not convinced that changing the |
This is a temporary step to remove the star imports, which are not recommended. It's always possible to remove the extra globals in a future PR (which I may do), but the star imports need to be removed first. |
I'd argue we should be trying to remove duplicates from |
Your tool is wrong here: That isn't looking at |
@eric-wieser Thanks for the suggestions. However, I won't be working on this further until I can replace all of the star imports. |
This looks ugly, and that's because it is! Rather it simply exposes the ugliness that was hidden behind the star imports.
Goals for this PR:
Note: this PR will not attempt to remove duplicate imports, but it allows static analyzers to potentially solve gh-10198 with another PR.