8000 masked median of empty dimension fails · Issue #8703 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

masked median of empty dimension fails #8703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
juliantaylor opened this issue Feb 26, 2017 · 2 comments · Fixed by #8705
Closed

masked median of empty dimension fails #8703

juliantaylor opened this issue Feb 26, 2017 · 2 comments · Fixed by #8705
Labels
00 - Bug component: numpy.ma masked arrays
Milestone
1.12.1 release

Comments

@juliantaylor
Copy link
Contributor 
a = np.ma.masked_array(np.array([], dtype=float, ndmin=3))
np.ma.median(a, axis=2)

fails with

IndexError: index -1 is out of bounds for axis 2 with size 0

As integer indexing of empty slices does not work.
Normal median slices instead and returns the mean of an empty slice, so nan.

What should masked median return? a masked nan to somewhat match the normal median or an empty array again?
@juliantaylor juliantaylor added this to the 1.12.1 release milestone Feb 26, 2017
@charris
Copy link
Member
charris commented Feb 27, 2017

This is also an error in 1.11.3, so not a regression. I want to release 1.12.1 soon, so may not include a fix for this if it isn't ready.

@juliantaylor
Copy link
Contributor Author

hm that is a regression in 1.11.2, it does work in 1.11.1
there it returns nan, like the normal median so thats probably how we should fix it.

@juliantaylor juliantaylor mentioned this issue Feb 27, 2017
Merged
juliantaylor added a commit to juliantaylor/numpy that referenced this issue Feb 27, 2017
@juliantaylor
BUG: fix ma.median for empty ndarrays
05aa44d 
return nan as it did in 1.11 and same as normal median.
closes numpygh-8703
juliantaylor added a commit to juliantaylor/numpy that referenced this issue Feb 27, 2017
@juliantaylor
BUG: fix ma.median for empty ndarrays
0c2cde4 
return nan as it did in 1.11 and same as normal median.
closes numpygh-8703
juliantaylor added a commit that referenced this issue Feb 27, 2017
@juliantaylor
Merge pull request #8707 from juliantaylor/ma-median-empty-1.12
e50b4cb 
backport ma.median fix gh-8703 to 1.12
@eric-wieser eric-wieser mentioned this issue Feb 27, 2017
Closed
@juliantaylor juliantaylor mentioned this issue Feb 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
00 - Bug component: numpy.ma masked arrays
Projects
None yet
Milestone
1.12.1 release
Development

Successfully merging a pull request may close this issue.

BUG: fix ma.median for empty ndarrays juliantaylor/numpy
2 participants
@charris @juliantaylor
0