8000 Possible bug in numpy/ma/core.py · Issue #6045 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

Possible bug in numpy/ma/core.py #6045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
charris opened this issue Jul 4, 2015 · 2 comments
Closed

Possible bug in numpy/ma/core.py #6045

charris opened this issue Jul 4, 2015 · 2 comments
Labels
00 - Bug component: numpy.ma masked arrays

Comments

@charris
Copy link
Member
charris commented Jul 4, 2015

pyflakes notes the _sharedmask is assigned but never used. I suspect this may be a bug. Note the the FIXME message is not yet in master.

        if hasattr(data, '_mask') and not isinstance(data, ndarray):
            _data._mask = data._mask
            # FIXME _sharedmask is never used.
            _sharedmask = True
@saimn
Copy link
Contributor
saimn commented Dec 1, 2015

I saw this one while looking at the code, the lines below uses _data._sharedmask, and it seems safe to do this change. Any idea when this "compatibility" code should be executed ? (It needs something that has a ._mask attribute but doesn't inherit from ndarray).

@WarrenWeckesser
Copy link
Member

The unused variable was fixed in #19102 (but see #20372 and #20386).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
00 - Bug component: numpy.ma masked arrays
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@charris @saimn @WarrenWeckesser
0