-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
Deprecate ndim > 2 behavior in dot for 1.9 #4397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There is an implementation for this in umath_linalg that can be |
Also, changing behavior of dot sounds a bit annoying change from the POV of downstream users. It might be better for backward compatibilty to add a new function ( |
+1 I think a new function should be implemented regardless of any deprecations to nail down the new semantics. I will open a separate issue for that unless someone beats me to it. |
The functionality is already available, even if undocumented, in
If a new function was created and exposed, it should probably use DGEEM, which |
I suggest: Different steps as intended to occur some time apart, like a year maybe. Eventually we could as step 4 remove the matrix_multiply alias, but there
|
Why did |
It didn't, it just never existed in the public API. |
Yes, I understand that, but it was ready to be included in the gufuncs version of |
I don't remember what happened, but probably we decided we didn't want to T
8000
here's also the problem that the gufunc as written doesn't handle 1d
|
The point was that the stuff was not ready to be included, and nobody at the time wanted to spend time cleaning the stuff up. There is an issue tracking the situation: gh-3217 |
Closing this, we cannot deprecate the |
Given that numpy is moving toward allowing its linear algebra routines to operate on (k, m,n) arrays where the array represents a stack of k, (m, n) matrices, it is important to provide a matrix multiply that can operate on such objects without unnecessary contortions. The current behavior for np.dot with ndim > 2 doesn't provide this. As the first step to providing it, the ndim > 2 behavior should be deprecated in the next release so that it can be changed sooner rather than later.
I would suggest that this be a 1.9 blocker.
The text was updated successfully, but these errors were encountered: