MNT: np.set_string_function implementation should be removed
#26576
Assignees
Comments
np.set_string_function implementation was neverremovednp.set_string_function implementation should be removed
np.set_string_function implementation should be removednp.set_string_function implementation should be removed
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@mtsokol removed
set_string_functionfrom the public API in #24376, but the code and underlying C implementation are still in the codebase. The python version is marked as deprecated but the equivalent C API isn't.We should replace the usages in docstrings with
printoptionsand remove it from the codebase. This also includes the public C API functionPyArray_SetStringFunctionwhich we may need to just stub out but leave behind for API stability, unfortunately this was missed for 2.0. A github search finds no usages outside of numpy itself or re-exports of the numpy C API.The main reason I'd like to do this is this API is implemented using global variables and is not thread-safe. There's no reason to update code to be thread safe if it's private and only needed for a deprecated function that is no longer public.
The text was updated successfully, but these errors were encountered: