-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
DOC: Change to np.bool
not mentioned in the migration guide
#26203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It's not a breaking change; |
@rgommers Oh I must've missed that then, I was under the impression that |
yes, long ago - that was deprecated in 1.20.0 and then removed in 1.24.0. It's noted in the 1.24.0 release notes as a breaking change. |
Either way, shouldn't this still be in the migration guide, since |
Not really, since (as you found out) it's hard to use |
A wise man said in #25080 (comment) that
Which in my mind falls into the category of "deprecated, do not use". Or is this a miscategorization on my part? |
More or less - "discouraged, do not use for new code" I'd say. At some point we'll probably deprecate it, and then it'll start emitting a warning, so if that's release 2.6.0 or so, it will end up in the notes for that release. "deprecated" has a very well-defined meaning (https://numpy.org/neps/nep-0023-backwards-compatibility.html), and will cause many downstream projects to have to migrate away from it straight away, since they turn warnings into errors in their CI. |
Ok that clears things up, thanks 😄 |
Uh oh!
There was an error while loading. Please reload this page.
Issue with current documentation:
The changes to
np.bool
are mentioned in the 2.0.0 release notes, but I can't find anything about it in the migration guide,even though it's a breaking change.related to #26199
Idea or request for content:
No response
The text was updated successfully, but these errors were encountered: