8000 ENH: Update to Cython 0.29.29. · Issue #21316 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content
8000

ENH: Update to Cython 0.29.29. #21316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
felixxm opened this issue Apr 10, 2022 · 3 comments
Closed

ENH: Update to Cython 0.29.29. #21316

felixxm opened this issue Apr 10, 2022 · 3 comments
Labels
14 - Release
Milestone
1.23.0 release

Comments

@felixxm
Copy link
Contributor
felixxm commented Apr 10, 2022

Proposed new feature or change:

We should update to Cython 0.29.29 (when released) and no longer pin to 0.29.x branch on Python 3.11+.

See #21308.
@rgommers rgommers added this to the 1.23.0 release milestone Apr 24, 2022
@rgommers
Copy link
Member

Thanks. Marked for the next release, would indeed be good to just unconditionally do >=0.29.29,<3.0.

and no longer pin to 0.29.x branch on Python 3.11+.

This part seems wrong, we want to keep the <3.0 part of the requirement. Note that you're perfectly free to build with 3.0 alphas locally, we just shouldn't do that in pyproject.toml.

@EwoutH
Copy link
Contributor
EwoutH commented May 10, 2022

I opened a PR over at Cython (cython/cython#4780) to start testing Python 3.11 without allowed_failure tag enabled. There are currently two issues found with Python 3.11 on the master branch, when they are fixed and the CI PR is merged I will suggest cherry picking them to the 0.29.x branch.

@felixxm felixxm mentioned this issue May 16, 2022
Merged
@mattip
Copy link
Member
mattip commented May 17, 2022

Closing, the PR was merged.

@mattip mattip closed this as completed May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
14 - Release
Projects
None yet
Milestone
1.23.0 release
Development

No branches or pull requests
4 participants
@rgommers @mattip @felixxm @EwoutH
0