8000 gitpod build is failing after merging a PR · Issue #19103 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

gitpod build is failing after merging a PR #19103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattip opened this issue May 26, 2021 · 8 comments · Fixed by #19119
Closed

gitpod build is failing after merging a PR #19103

mattip opened this issue May 26, 2021 · 8 comments · Fixed by #19119

Comments

@mattip
Copy link
Member
mattip commented May 26, 2021

I got a message that a github actions job failed after merging a PR. Rerunning the job did not clear the error. The error is in the gitpod docker build:

buildx call failed with: error: failed to solve: rpc error: code = Unknown desc = executor failed running [/bin/bash --login -o pipefail -c conda activate ${CONDA_ENV} &&     python setup.py build_ext --inplace &&     ccache -s]: exit

@trallard thoughts?
@trallard
Copy link
Contributor

The actual error is happening when calling python setup.py build_ext --inplace:

#14 1.657 Traceback (most recent call last):
#14 1.657   File "/workspace/numpy/setup.py", line 57, in <module>
#14 1.658     MAJOR, MINOR, MICRO = re.match(r'(\d+)\.(\d+)\.(\d+)', FULLVERSION).groups()
#14 1.658 AttributeError: 'NoneType' object has no attribute 'groups'

See https://github.com/numpy/numpy/runs/2671818624?check_suite_focus=true#step:9:225 so it all seems it's failing at identifying the NumPy version for the build

@charris
Copy link
Member
charris commented May 26, 2021

I suspect

RUN git clone --depth 1

@charris
Copy link
Member
charris commented May 26, 2021

In particular, the use of --depth 1.

@trallard
Copy link
Contributor

This has not been an issue before 🤔 - we are using the shallow clone to avoid bloating the image

@charris
Copy link
Member
charris commented May 26, 2021

The version needs to be deep enough to reach the tagged commit v1.22.0.dev0. I had to fix the clone depth for wheel builds when we started using versioneer. The --single-branch option might be useful, although I think it may be the default. I suspect working incorrectly before.

@charris
Copy link
Member
charris commented May 26, 2021

I would be interesting to see what FULLVERSION was before.

@trallard
Copy link
Contributor

Will have a look - later today or tomorrow. It was working fine for dev tags and the reason to do the git clone in the first time was for versioneer to work else there was no way to get the build working.

--single-branch should be the default so no need to tweak it. 😉

@charris
Copy link
Member
charris commented May 26, 2021

I tested with a local clone and depth=1 did not provide any tags. However

git clone --shallow-since=1/1/2021 file:///home/charris/Workspace/numpy.git test-numpy

did work and was considerably smaller (10734 vs 179319 objects) than a full clone.

@trallard trallard mentioned this issue May 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: Adjust shallow clone in the gitpod container
3 participants
@charris @mattip @trallard
0