8000 REL: Revert #14800 for 1.18. · Issue #14839 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

REL: Revert #14800 for 1.18. #14839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
charris opened this issue Nov 6, 2019 · 3 comments
Closed

REL: Revert #14800 for 1.18. #14839

charris opened this issue Nov 6, 2019 · 3 comments
Labels
14 - Release 17 - Task
Milestone
1.18.0 release

Comments

@charris
Copy link
Member
charris commented Nov 6, 2019

The change in object array comparisons in #14800 breaks Pandas.

Reproducing code example:

import numpy as np
<< your code here >>

Error message:

Numpy/Python version information:
@charris charris added this to the 1.18.0 release milestone Nov 6, 2019
@mattip
Copy link
Member
mattip commented Nov 6, 2019

Did pandas tests break?

@charris
Copy link
Member Author
charris commented Nov 6, 2019

Yes, see the comments in the PR.

@charris
Copy link
Member Author
charris commented Nov 6, 2019

Is reverted, so closing.

@charris charris closed this as completed Nov 6, 2019
@mattip mattip mentioned this issue Dec 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
14 - Release 17 - Task
Projects
None yet
Milestone
1.18.0 release
Development

No branches or pull requests
2 participants
@charris @mattip
0