8000 PocketFFT missing LICENSE.md · Issue #14552 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

PocketFFT missing LICENSE.md #14552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sandrotosi opened this issue Sep 20, 2019 · 4 comments · Fixed by #14557
Closed

PocketFFT missing LICENSE.md #14552

sandrotosi opened this issue Sep 20, 2019 · 4 comments · Fixed by #14557
Assignees
@rgommers
Labels
04 - Documentation
Milestone
1.17.3 release

Comments

@sandrotosi
Copy link
Contributor

Hello,
numpy/fft/README.md says

License

3-clause BSD (see LICENSE.md)

but no LICENSE.md file is present in the repo (and thus the release tarball too).

Could you please include that file too? thanks!
@rgommers
Copy link
Member

Thanks @sandrotosi.

Since none of this code is in an external package anymore, it may make more sense to remove the mention of a license from that README rather than add a separate license file. It can simply be covered by the NumPy BSD license. @mreineck would that be fine with you? If not, can you point me to the LICENSE.md file that's in the README?

@rgommers rgommers added this to the 1.17.3 release milestone Sep 20, 2019
@rgommers rgommers self-assigned this Sep 20, 2019
@sandrotosi
Copy link
Contributor Author

it still lives here: https://gitlab.mpcdf.mpg.de/mtr/pocketfft (included the LICENSE.md file)

@mreineck
Copy link
Contributor

I'm fine with either change! Sorry, can't produce a patch right now, will be back at a decent computer in a few days.

@rgommers
Copy link
Member

thanks @mreineck. I'll open a PR now.

rgommers added a commit to rgommers/numpy that referenced this issue Sep 20, 2019
@rgommers
DOC: remove note about Pocketfft license file (non-existing here).
43bc819 
Closes numpygh-14552

The Pocketfft author (mreineck) agreed on numpygh-14552 that Pocketfft can
simply fall under the NumPy license, no separate license file needed.

[ci skip]
@rgommers rgommers mentioned this issue Sep 20, 2019
Merged
rgommers added a commit to rgommers/numpy that referenced this issue Sep 21, 2019
@rgommers
DOC: remove note about Pocketfft license file (non-existing here).
5504e6d 
Closes numpygh-14552

The Pocketfft author (mreineck) agreed on numpygh-14552 that Pocketfft can
simply fall under the NumPy license, no separate license file needed.

[ci skip]

(cherry picked from commit 43bc819)
@rgommers rgommers mentioned this issue Sep 21, 2019
Merged
@rgommers rgommers mentioned this issue Nov 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgommers rgommers

Labels
04 - Documentation
Projects
None yet
Milestone
1.17.3 release
Development

Successfully merging a pull request may close this issue.

DOC: remove note about Pocketfft license file (non-existing here). rgommers/numpy
3 participants
@rgommers @sandrotosi @mreineck
0