8000 Apply review comments · numpy/numpy@eb6a10a · GitHub
[go: up one dir, main page]
Skip to content

Commit eb6a10a

Browse files
mtsokolmtsokol
committed
Apply review comments
1 parent cee5097 commit eb6a10a

File tree

3 files changed

+5
-39
lines changed

3 files changed

+5
-39
lines changed

‎doc/release/upcoming_changes/24587.python_removal.rst

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
* ``np.compare_chararrays`` has been removed from the main namespace.
22
Use ``np.char.compare_chararrays`` instead.
33

4-
* ``np.chararray`` has been deprecated and it will be removed in the future.
5-
Use ``np.char.chararray`` instead.
4+
* The ``charrarray`` in the main namespace has been deprecated. It can be imported
5+
without a deprecation warning from ``np.char.chararray`` for now,
6+
but we are planning to fully deprecate and remove ``chararray`` in the future.
67

78
* ``np.format_parser`` has been removed from the main namespace.
89
Use ``np.rec.format_parser`` instead.

‎numpy/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -393,8 +393,8 @@ def __getattr__(attr):
393393
if attr == "chararray":
394394
warnings.warn(
395395
"`np.chararray` is deprecated and will be removed from "
396-
"the main namespace in the future. Use `np.char.chararray` "
397-
"instead.", DeprecationWarning, stacklevel=2)
396+
"the main namespace in the future. Use an array with a string "
397+
"or bytes dtype instead.", DeprecationWarning, stacklevel=2)
398398
import numpy.char as char
399399
return char.chararray
400400

‎numpy/setup.py

Lines changed: 0 additions & 35 deletions
This file was deleted.

0 commit comments

Comments
 (0)
0