Check ufunc's dict on creation

mtsokol · mtsokol · commit ccdeffbfd89b · 2024-11-12T13:27:23.000Z
diff --git a/numpy/_core/src/umath/ufunc_object.c b/numpy/_core/src/umath/ufunc_object.c
@@ -4772,6 +4772,10 @@ PyUFunc_FromFuncAndDataAndSignatureAndIdentity(PyUFuncGenericFunction *func, voi
         }
     }
     ufunc->dict = PyDict_New();
+    if (ufunc->dict == NULL) {
+        Py_DECREF(ufunc);
+        return NULL;
+    }
     /*
      * TODO: I tried adding a default promoter here (either all object for
      *       some special cases, or all homogeneous).  Those are reasonable
@@ -5199,7 +5203,7 @@ ufunc_traverse(PyUFuncObject *self, visitproc visit, void *arg)
     if (self->identity == PyUFunc_IdentityValue) {
         Py_VISIT(self->identity_value);
     }
-    Py_VISIT(self->dict);
+    //Py_VISIT(self->dict);
     return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -4772,6 +4772,10 @@ PyUFunc_FromFuncAndDataAndSignatureAndIdentity(PyUFuncGenericFunction *func, voi`
`4772`	`4772`	`}`
`4773`	`4773`	`}`
`4774`	`4774`	`ufunc->dict = PyDict_New();`
	`4775`	`+ if (ufunc->dict == NULL) {`
	`4776`	`+ Py_DECREF(ufunc);`
	`4777`	`+ return NULL;`
	`4778`	`+ }`
`4775`	`4779`	`/*`
`4776`	`4780`	`* TODO: I tried adding a default promoter here (either all object for`
`4777`	`4781`	`* some special cases, or all homogeneous). Those are reasonable`
`@@ -5199,7 +5203,7 @@ ufunc_traverse(PyUFuncObject self, visitproc visit, void arg)`
`5199`	`5203`	`if (self->identity == PyUFunc_IdentityValue) {`
`5200`	`5204`	`Py_VISIT(self->identity_value);`
`5201`	`5205`	`}`
`5202`		`- Py_VISIT(self->dict);`
	`5206`	`+ //Py_VISIT(self->dict);`
`5203`	`5207`	`return 0;`
`5204`	`5208`	`}`
`5205`	`5209`