TYP: Deprecate calling numpy.save with fix_imports (PEP 702)

jorenham · jorenham · commit be72b3d1f16f · 2024-08-14T00:14:54.000+02:00
diff --git a/numpy/lib/_npyio_impl.pyi b/numpy/lib/_npyio_impl.pyi
@@ -13,6 +13,7 @@ from typing import (
     overload,
     Protocol,
 )
+from typing_extensions import deprecated
 
 from numpy import (
     ndarray,
@@ -129,11 +130,29 @@ def load(
     encoding: L["ASCII", "latin1", "bytes"] = ...,
 ) -> Any: ...
 
+@overload
 def save(
     file: str | os.PathLike[str] | _SupportsWrite[bytes],
     arr: ArrayLike,
     allow_pickle: bool = ...,
-    fix_imports: bool = ...,
+) -> None: ...
+@overload
+@deprecated("The 'fix_imports' flag is deprecated in NumPy 2.1.")
+def save(
+    file: str | os.PathLike[str] | _SupportsWrite[bytes],
+    arr: ArrayLike,
+    allow_pickle: bool = ...,
+    *,
+    fix_imports: bool,
+) -> None: ...
+@overload
+@deprecated("The 'fix_imports' flag is deprecated in NumPy 2.1.")
+def save(
+    file: str | os.PathLike[str] | _SupportsWrite[bytes],
+    arr: ArrayLike,
+    allow_pickle: bool,
+    fix_imports: bool,
+    /,
 ) -> None: ...
 
 def savez(
diff --git a/numpy/typing/tests/data/fail/npyio.pyi b/numpy/typing/tests/data/fail/npyio.pyi
@@ -12,7 +12,9 @@ AR_i8: npt.NDArray[np.int64]
 
 np.load(str_file)  # E: incompatible type
 
-np.save(bytes_path, AR_i8)  # E: incompatible type
+np.save(bytes_path, AR_i8)  # E: No overload variant
+# https://github.com/python/mypy/issues/16111
+# np.save(str_path, AR_i8, fix_imports=True)  # W: deprecated
 
 np.savez(bytes_path, AR_i8)  # E: incompatible type
 
