BUG: Closes #5313 PyArray_AsCArray caused segfault

hensing · hensing · commit a4163c4f3f00 · 2014-11-30T22:41:48.000+01:00
diff --git a/numpy/core/src/multiarray/multiarraymodule.c b/numpy/core/src/multiarray/multiarraymodule.c
@@ -220,7 +220,7 @@ PyArray_AsCArray(PyObject **op, void *ptr, npy_intp *dims, int nd,
             goto fail;
         }
         for (i = 0; i < n; i++) {
-            ptr3[i] = ptr3[n + (m-1)*i];
+            ptr3[i] = (char **) &ptr3[n + m * i];
             for (j = 0; j < m; j++) {
                 ptr3[i][j] = PyArray_BYTES(ap) + i*PyArray_STRIDES(ap)[0] + j*PyArray_STRIDES(ap)[1];
             }

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,7 @@ PyArray_AsCArray(PyObject *op, void ptr, npy_intp *dims, int nd,`
`220`	`220`	`goto fail;`
`221`	`221`	`}`
`222`	`222`	`for (i = 0; i < n; i++) {`
`223`		`- ptr3[i] = ptr3[n + (m-1)*i];`
	`223`	`+ ptr3[i] = (char *) &ptr3[n + m i];`
`224`	`224`	`for (j = 0; j < m; j++) {`
`225`	`225`	`ptr3[i][j] = PyArray_BYTES(ap) + iPyArray_STRIDES(ap)[0] + jPyArray_STRIDES(ap)[1];`
`226`	`226`	`}`