Merge pull request #7152 from bertrand-l/fix/unicode-kwarg-breaks-pad

charris · charris · commit 3bc8ed46d0fc · 2016-01-31T12:13:52.000-07:00
BUG: mode kwargs passed as unicode to np.pad raises an exception
diff --git a/numpy/lib/arraypad.py b/numpy/lib/arraypad.py
@@ -1337,7 +1337,7 @@ def pad(array, pad_width, mode, **kwargs):
         'reflect_type': 'even',
         }
 
-    if isinstance(mode, str):
+    if isinstance(mode, np.compat.basestring):
         # Make sure have allowed kwargs appropriate for mode
         for key in kwargs:
             if key not in allowedkwargs[mode]:
diff --git a/numpy/lib/tests/test_arraypad.py b/numpy/lib/tests/test_arraypad.py
@@ -953,6 +953,17 @@ def test_check_simple(self):
         assert_array_equal(a, b)
 
 
+class TestUnicodeInput(TestCase):
+    def test_unicode_mode(self):
+        try:
+            constant_mode = unicode('constant')
+        except NameError:
+            constant_mode = 'constant'
+        a = np.pad([1], 2, mode=constant_mode)
+        b = np.array([0, 0, 1, 0, 0])
+        assert_array_equal(a, b)
+
+
 class ValueError1(TestCase):
     def test_check_simple(self):
         arr = np.arange(30)

Original file line number	Diff line number	Diff line change
`@@ -1337,7 +1337,7 @@ def pad(array, pad_width, mode, **kwargs):`
`1337`	`1337`	`'reflect_type': 'even',`
`1338`	`1338`	`}`
`1339`	`1339`
`1340`		`- if isinstance(mode, str):`
	`1340`	`+ if isinstance(mode, np.compat.basestring):`
`1341`	`1341`	`# Make sure have allowed kwargs appropriate for mode`
`1342`	`1342`	`for key in kwargs:`
`1343`	`1343`	`if key not in allowedkwargs[mode]:`