MNT: delete unnecessary decrefs (covered by goto fail logic)

ngoldbaum · ngoldbaum · commit 26f74212c47e · 2024-04-16T10:50:46.000-06:00
diff --git a/numpy/_core/src/multiarray/ctors.c b/numpy/_core/src/multiarray/ctors.c
@@ -2394,22 +2394,19 @@ PyArray_FromInterface(PyObject *origin)
             PyErr_SetString(PyExc_TypeError,
                     "strides must be a tuple");
             Py_DECREF(ret);
-            Py_DECREF(attr);
             goto fail;
         }
         if (n != PyTuple_GET_SIZE(attr)) {
             PyErr_SetString(PyExc_ValueError,
                     "mismatch in length of strides and shape");
             Py_DECREF(ret);
-            Py_DECREF(attr);
             goto fail;
         }
         for (i = 0; i < n; i++) {
             PyObject *tmp = PyTuple_GET_ITEM(attr, i);
             strides[i] = PyArray_PyIntAsIntp(tmp);
             if (error_converting(strides[i])) {
                 Py_DECREF(ret);
-                Py_DECREF(attr);
                 goto fail;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -2394,22 +2394,19 @@ PyArray_FromInterface(PyObject *origin)`
`2394`	`2394`	`PyErr_SetString(PyExc_TypeError,`
`2395`	`2395`	`"strides must be a tuple");`
`2396`	`2396`	`Py_DECREF(ret);`
`2397`		`- Py_DECREF(attr);`
`2398`	`2397`	`goto fail;`
`2399`	`2398`	`}`
`2400`	`2399`	`if (n != PyTuple_GET_SIZE(attr)) {`
`2401`	`2400`	`PyErr_SetString(PyExc_ValueError,`
`2402`	`2401`	`"mismatch in length of strides and shape");`
`2403`	`2402`	`Py_DECREF(ret);`
`2404`		`- Py_DECREF(attr);`
`2405`	`2403`	`goto fail;`
`2406`	`2404`	`}`
`2407`	`2405`	`for (i = 0; i < n; i++) {`
`2408`	`2406`	`PyObject *tmp = PyTuple_GET_ITEM(attr, i);`
`2409`	`2407`	`strides[i] = PyArray_PyIntAsIntp(tmp);`
`2410`	`2408`	`if (error_converting(strides[i])) {`
`2411`	`2409`	`Py_DECREF(ret);`
`2412`		`- Py_DECREF(attr);`
`2413`	`2410`	`goto fail;`
`2414`	`2411`	`}`
`2415`	`2412`	`}`