MAINT: add TODO comments for pcg64 improvements

mattip · mattip · commit 161f69e224b0 · 2019-03-23T19:18:58.000+02:00
diff --git a/numpy/random/randomgen/pcg64.pyx b/numpy/random/randomgen/pcg64.pyx
@@ -278,6 +278,7 @@ cdef class PCG64:
             state of the RNG
         """
         # IF PCG_EMULATED_MATH==1:
+        # TODO: push this into an #ifdef in the C code
         state = 2 **64 * self.rng_state.pcg_state.state.high
         state += self.rng_state.pcg_state.state.low
         inc = 2 **64 * self.rng_state.pcg_state.inc.high
diff --git a/numpy/random/randomgen/setup.py b/numpy/random/randomgen/setup.py
@@ -76,6 +76,8 @@ def generate_libraries(ext, build_dir):
             EXTRA_INCLUDE_DIRS += [join(MOD_DIR, 'src', 'common')]
 
     PCG64_DEFS = []
+    # TODO: remove the unconditional forced emulation, move code from pcg64.pyx
+    # to an #ifdef
     if 1 or sys.maxsize < 2 ** 32 or os.name == 'nt':
         # Force emulated mode here
         PCG_EMULATED_MATH = True
