BUG: Add missing names decref to argsort/argpartition (sort is good)

seberg · seberg · commit 0f1500a7d7e1 · 2018-12-31T01:48:52.000+01:00
also partition is already good.
diff --git a/numpy/core/src/multiarray/methods.c b/numpy/core/src/multiarray/methods.c
@@ -1381,6 +1381,7 @@ array_argsort(PyArrayObject *self, PyObject *args, PyObject *kwds)
             return NULL;
         }
         newd = PyArray_DescrNew(saved);
+        Py_DECREF(newd->names);
         newd->names = new_name;
         ((PyArrayObject_fields *)self)->descr = newd;
     }
@@ -1435,6 +1436,7 @@ array_argpartition(PyArrayObject *self, PyObject *args, PyObject *kwds)
             return NULL;
         }
         newd = PyArray_DescrNew(saved);
+        Py_DECREF(newd->names);
         newd->names = new_name;
         ((PyArrayObject_fields *)self)->descr = newd;
     }

Original file line number	Diff line number	Diff line change
`@@ -1381,6 +1381,7 @@ array_argsort(PyArrayObject self, PyObject args, PyObject *kwds)`
`1381`	`1381`	`return NULL;`
`1382`	`1382`	`}`
`1383`	`1383`	`newd = PyArray_DescrNew(saved);`
	`1384`	`+ Py_DECREF(newd->names);`
`1384`	`1385`	`newd->names = new_name;`
`1385`	`1386`	`((PyArrayObject_fields *)self)->descr = newd;`
`1386`	`1387`	`}`
`@@ -1435,6 +1436,7 @@ array_argpartition(PyArrayObject self, PyObject args, PyObject *kwds)`
`1435`	`1436`	`return NULL;`
`1436`	`1437`	`}`
`1437`	`1438`	`newd = PyArray_DescrNew(saved);`
	`1439`	`+ Py_DECREF(newd->names);`
`1438`	`1440`	`newd->names = new_name;`
`1439`	`1441`	`((PyArrayObject_fields *)self)->descr = newd;`
`1440`	`1442`	`}`