8000 Merge pull request #5873 from charris/style-fix-for-cov · numpy/numpy@0174f2a · GitHub
[go: up one dir, main page]

Skip to content
< 8000 header class="HeaderMktg header-logged-out js-details-container js-header Details f4 py-3" role="banner" data-is-top="true" data-color-mode=light data-light-theme=light data-dark-theme=dark>

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 0174f2a

Browse files
committed
Merge pull request #5873 from charris/style-fix-for-cov
MAINT: Simplify code in cov function a bit.
2 parents 9ceb5cd + a0bd6c7 commit 0174f2a

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

numpy/lib/function_base.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2006,13 +2006,12 @@ def cov(m, y=None, rowvar=1, bias=0, ddof=None, fweights=None, aweights=None):
20062006
# Determine the normalization
20072007
if w is None:
20082008
fact = float(X.shape[1] - ddof)
2009+
elif ddof == 0:
2010+
fact = w_sum
2011+
elif aweights is None:
2012+
fact = w_sum - ddof
20092013
else:
2010-
if ddof == 0:
2011-
fact = w_sum
2012-
elif aweights is None:
2013-
fact = w_sum - ddof
2014-
else:
2015-
fact = w_sum - ddof*sum(w*aweights)/w_sum
2014+
fact = w_sum - ddof*sum(w*aweights)/w_sum
20162015

20172016
if fact <= 0:
20182017
warnings.warn("Degrees of freedom <= 0 for slice", RuntimeWarning)

0 commit comments

Comments
 (0)
0