Use safer method to prevent tooltips moving (microbit-foundation#680)

microbit-robert · web-flow · commit adfc3ea93c3c · 2022-04-14T15:41:44.000+01:00
diff --git a/src/editor/codemirror/lint/lint.ts b/src/editor/codemirror/lint/lint.ts
@@ -704,8 +704,11 @@ function trackHoverOn(view: EditorView, marker: HTMLElement) {
 }
 
 function gutterMarkerMouseOver(view: EditorView, marker: HTMLElement, diagnostics: readonly Diagnostic[]) {
-  let line = view.elementAtHeight(marker.getBoundingClientRect().top + 5 - view.documentTop)
   function hovered() {
+    if (marker.getBoundingClientRect().top === 0) {
+      return
+    }
+    let line = view.elementAtHeight(marker.getBoundingClientRect().top + 5 - view.documentTop)
     const linePos = view.coordsAtPos(line.from)
     if (linePos) {
       view.dispatch({effects: setLintGutterTooltip.of({
@@ -719,6 +722,7 @@ function gutterMarkerMouseOver(view: EditorView, marker: HTMLElement, diagnostic
         }
       })})
     }
+   
     marker.onmouseout = marker.onmousemove = null
     trackHoverOn(view, marker)
   }

Original file line number	Diff line number	Diff line change
`@@ -704,8 +704,11 @@ function trackHoverOn(view: EditorView, marker: HTMLElement) {`
`704`	`704`	`}`
`705`	`705`
`706`	`706`	`function gutterMarkerMouseOver(view: EditorView, marker: HTMLElement, diagnostics: readonly Diagnostic[]) {`
`707`		`- let line = view.elementAtHeight(marker.getBoundingClientRect().top + 5 - view.documentTop)`
`708`	`707`	`function hovered() {`
	`708`	`+ if (marker.getBoundingClientRect().top === 0) {`
	`709`	`+ return`
	`710`	`+ }`
	`711`	`+ let line = view.elementAtHeight(marker.getBoundingClientRect().top + 5 - view.documentTop)`
`709`	`712`	`const linePos = view.coordsAtPos(line.from)`
`710`	`713`	`if (linePos) {`
`711`	`714`	`view.dispatch({effects: setLintGutterTooltip.of({`
`@@ -719,6 +722,7 @@ function gutterMarkerMouseOver(view: EditorView, marker: HTMLElement, diagnostic`
`719`	`722`	`}`
`720`	`723`	`})})`
`721`	`724`	`}`
	`725`	`+`
`722`	`726`	`marker.onmouseout = marker.onmousemove = null`
`723`	`727`	`trackHoverOn(view, marker)`
`724`	`728`	`}`