Avoid nested updates closing signature help. (microbit-foundation#1058)

microbit-matt-hillsdon · web-flow · commit 9d066cf0c7d6 · 2022-10-29T20:40:57.000+01:00
Fixes issue observed on beta.
diff --git a/src/editor/codemirror/language-server/signatureHelp.ts b/src/editor/codemirror/language-server/signatureHelp.ts
@@ -316,9 +316,12 @@ export const signatureHelp = (
           !(event.relatedTarget instanceof Element) ||
           !event.relatedTarget.closest(".cm-signature-tooltip")
         ) {
-          view.dispatch({
-            effects: setSignatureHelpRequestPosition.of(-1),
-          });
+          // This can be called inside an update.
+          setTimeout(() => {
+            view.dispatch({
+              effects: setSignatureHelpRequestPosition.of(-1),
+            });
+          }, 0);
         }
       },
     }),
