8000 Collapse display.show overloads to correspond to reality (#681) · nsavas2000/python-editor-v3@4463a34 · GitHub
[go: up one dir, main page]

Skip to content

Commit 4463a34

Browse files
Collapse display.show overloads to correspond to reality (microbit-foundation#681)
Fixes display.scroll(value -> text) parameter name.
1 parent 81746a2 commit 4463a34

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

src/e2e/autocomplete.test.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
*/
66
import { App } from "./app";
77

8+
const showFullSignature =
9+
"show(image, delay=400, wait=True, loop=False, clear=False)";
10+
811
describe("Browser - autocomplete and signature help tests", () => {
912
// Enable flags to allow testing the toolkit interactions.
1013
const app = new App();
@@ -18,7 +21,7 @@ describe("Browser - autocomplete and signature help tests", () => {
1821

1922
// Initial completions
2023
await app.findCompletionOptions(["scroll", "set_pixel", "show"]);
21-
await app.findCompletionActiveOption("scroll(value)");
24+
await app.findCompletionActiveOption("scroll(text)");
2225

2326
// Further refinement
2427
await app.typeInEditor("h");
@@ -47,15 +50,15 @@ describe("Browser - autocomplete and signature help tests", () => {
4750

4851
await app.followCompletionOrSignatureDocumentionLink();
4952

50-
await app.findActiveDocumentationEntry("show(image)");
53+
await app.findActiveDocumentationEntry(showFullSignature);
5154
});
5255

5356
it("shows signature help after autocomplete", async () => {
5457
await app.selectAllInEditor();
5558
await app.typeInEditor("from microbit import *\ndisplay.sho");
5659
await app.acceptCompletion("show");
5760

58-
await app.findSignatureHelp("show(image)");
61+
await app.findSignatureHelp(showFullSignature);
5962
});
6063

6164
it("does not insert brackets for import completion", async () => {
@@ -72,7 +75,7 @@ describe("Browser - autocomplete and signature help tests", () => {
7275
// The closing bracket is autoinserted.
7376
await app.typeInEditor("from microbit import *\ndisplay.show(");
7477

75-
await app.findSignatureHelp("show(image)");
78+
await app.findSignatureHelp(showFullSignature);
7679

7780
await app.followCompletionOrSignatureDocumentionLink();
7881

0 commit comments

Comments
 (0)
0