8000 Merge pull request #199 from notion-dotnet/bugfix/191-register-the-bl… · notion-dotnet/notion-sdk-net@6ef3a9a · GitHub
[go: up one dir, main page]

Skip to content

Commit 6ef3a9a

Browse files
Merge pull request #199 from notion-dotnet/bugfix/191-register-the-block-sub-type
Fix: Register Divider block & added test cases 🐛
2 parents 139d68e + 3bb969c commit 6ef3a9a

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

Src/Notion.Client/Models/Blocks/Block.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ namespace Notion.Client
1010
[JsonSubtypes.KnownSubType(typeof(ChildPageBlock), BlockType.ChildPage)]
1111
[JsonSubtypes.KnownSubType(typeof(ChildDatabaseBlock), BlockType.ChildDatabase)]
1212
[JsonSubtypes.KnownSubType(typeof(CodeBlock), BlockType.Code)]
13+
[JsonSubtypes.KnownSubType(typeof(DividerBlock), BlockType.Divider)]
1314
[JsonSubtypes.KnownSubType(typeof(EmbedBlock), BlockType.Embed)]
1415
[JsonSubtypes.KnownSubType(typeof(EquationBlock), BlockType.Equation)]
1516
[JsonSubtypes.KnownSubType(typeof(FileBlock), BlockType.File)]

Test/Notion.IntegrationTests/IBlocksClientTests.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,16 @@ private static IEnumerable<object[]> BlockData()
258258
var updatedBlock = (EquationBlock)block;
259259
Assert.Equal("e=mc^2", updatedBlock.Equation.Expression);
260260
})
261+
},
262+
new object[] {
263+
new DividerBlock {
264+
Divider = new DividerBlock.Data()
265+
},
266+
new DividerUpdateBlock(),
267+
new Action<Block>((block) => {
268+
Assert.NotNull(block);
269+
Assert.IsType<DividerBlock>(block);
270+
})
261271
}
262272
};
263273
}

0 commit comments

Comments
 (0)
0