socket_select was incorrectly in blocking mode

Lindsay Snider · Lindsay Snider · commit e934b04a2316 · 2014-01-03T17:03:04.000-05:00
null being passed as a time out parameter was making it to the socket_select call.  the intention was to have the socket_select call be in non blocking mode by defaulting to zero but passing null in made socket_select blocking.  the result was the parent would hang until a child would finish before being able to process more work.
diff --git a/fork_daemon.php b/fork_daemon.php
@@ -1451,7 +1451,7 @@ private function fetch_results($blocking = true, $timeout = 0, $bucket = self::D
 	private function post_results($bucket = self::DEFAULT_BUCKET)
 	{
 		// fetch all the results up to this point
-		$results = $this->fetch_results(false, null, $bucket);
+		$results = $this->fetch_results(false, 0, $bucket);
 		if (is_array($results) && empty($results))
 			return true;
 

Original file line number	Diff line number	Diff line change
`@@ -1451,7 +1451,7 @@ private function fetch_results($blocking = true, $timeout = 0, $bucket = self::D`
`1451`	`1451`	`private function post_results($bucket = self::DEFAULT_BUCKET)`
`1452`	`1452`	`{`
`1453`	`1453`	`// fetch all the results up to this point`
`1454`		`- $results = $this->fetch_results(false, null, $bucket);`
	`1454`	`+ $results = $this->fetch_results(false, 0, $bucket);`
`1455`	`1455`	`if (is_array($results) && empty($results))`
`1456`	`1456`	`return true;`
`1457`	`1457`