8000 assets: standardize "name" usage · noscripter/vue@deb43a8 · GitHub
[go: up one dir, main page]

Skip to content

Commit deb43a8

Browse files
committed
assets: standardize "name" usage
1 parent 9209c83 commit deb43a8

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

src/util/options.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ function guardComponents (options) {
231231
}
232232
def = components[key]
233233
if (_.isPlainObject(def)) {
234-
def.id = def.id || key
234+
def.name = def.name || key
235235
components[key] = def._Ctor || (def._Ctor = _.Vue.extend(def))
236236
}
237237
}
@@ -280,10 +280,10 @@ function guardArrayAssets (assets) {
280280
var asset
281281
while (i--) {
282282
asset = assets[i]
283-
var id = asset.id || (asset.options && asset.options.id)
283+
var id = asset.name || (asset.options && asset.options.name)
284284
if (!id) {
285285
process.env.NODE_ENV !== 'production' && _.warn(
286-
'Array-syntax assets must provide an id field.'
286+
'Array-syntax assets must provide a "name" field.'
287287
)
288288
} else {
289289
res[id] = asset

test/unit/specs/util/options_spec.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ describe('Util - Option merging', function () {
123123
}
124124
})
125125
expect(typeof res.components.test).toBe('function')
126-
expect(res.components.test.options.id).toBe('test')
126+
expect(res.components.test.options.name).toBe('test')
127127
expect(res.components.test.super).toBe(Vue)
128128
})
129129

@@ -282,11 +282,12 @@ describe('Util - Option merging', function () {
282282
}
283283
}
284284
var b = {
285-
components: [{ id: 'b' }]
285+
components: [{ name: 'b' }]
286286
}
287287
var res = merge(a, b)
288288
expect(res.components.a).toBe(a.components.a)
289289
// b.components is guarded and converted to object hash
290+
expect(res.components.b).toBeTruthy()
290291
expect(res.components.b).toBe(b.components.b)
291292
})
292293

@@ -300,7 +301,7 @@ describe('Util - Option merging', function () {
300301
components: [{}]
301302
}
302303
merge(a, b)
303-
expect(hasWarned(_, 'must provide an id')).toBe(true)
304+
expect(hasWarned(_, 'must provide a "name" field')).toBe(true)
304305
})
305306

306307
})

0 commit comments

Comments
 (0)
0