10000 add test for directive literal number arg + limitBy with v-for · noscripter/vue@14a1fb4 · GitHub
[go: up one dir, main page]

Skip to content

Commit 14a1fb4

Browse files
committed
add test for directive literal number arg + limitBy with v-for
1 parent e8efd64 commit 14a1fb4

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

test/unit/specs/directives/public/for/for_spec.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ if (_.inBrowser) {
372372
it('array filters', function (done) {
373373
var vm = new Vue({
374374
el: el,
375-
template: '<div v-for="item in list | filterBy filterKey | orderBy sortKey -1">{{item.id}}</div>',
375+
template: '<div v-for="item in list | filterBy filterKey | orderBy sortKey -1 | limitBy 2">{{item.id}}</div>',
376376
data: {
377377
filterKey: 'hi!',
378378
sortKey: 'id',
@@ -426,7 +426,9 @@ if (_.inBrowser) {
426426
})
427427
.map(function (item) {
428428
return '<div>' + item.id + '</div>'
429-
}).join('')
429+
})
430+
.slice(0, 2)
431+
.join('')
430432
expect(el.innerHTML).toBe(markup)
431433
}
432434
})

test/unit/specs/parsers/directive_spec.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,19 @@ describe('New Directive Parser', function () {
88
})
99

1010
it('with filters', function () {
11-
var res = parse('exp | abc de \'ok\' \'\' | bcd')
11+
var res = parse('exp | abc de \'ok\' \'\' 123 | bcd')
1212
expect(res.expression).toBe('exp')
1313
expect(res.filters.length).toBe(2)
1414
expect(res.filters[0].name).toBe('abc')
15-
expect(res.filters[0].args.length).toBe(3)
15+
expect(res.filters[0].args.length).toBe(4)
1616
expect(res.filters[0].args[0].value).toBe('de')
1717
expect(res.filters[0].args[0].dynamic).toBe(true)
1818
expect(res.filters[0].args[1].value).toBe('ok')
1919
expect(res.filters[0].args[1].dynamic).toBe(false)
2020
expect(res.filters[0].args[2].value).toBe('')
2121
expect(res.filters[0].args[2].dynamic).toBe(false)
22+
expect(res.filters[0].args[3].value).toBe(123)
23+
expect(res.filters[0].args[3].dynamic).toBe(false)
2224
expect(res.filters[1].name).toBe('bcd')
2325
expect(res.filters[1].args).toBeUndefined()
2426
})

0 commit comments

Comments
 (0)
0