[Process] Do not throw LogicException in ProcessBuilder::getProcess if no arguments are set but a prefix is

romainneutron · romainneutron · commit 1de29b9a7b5d · 2013-04-23T22:53:10.000+02:00
diff --git a/src/Symfony/Component/Process/ProcessBuilder.php b/src/Symfony/Component/Process/ProcessBuilder.php
@@ -154,7 +154,7 @@ public function setOption($name, $value)
 
     public function getProcess()
     {
-        if (!count($this->arguments)) {
+        if (!$this->prefix && !count($this->arguments)) {
             throw new LogicException('You must add() command arguments before calling getProcess().');
         }
 
diff --git a/src/Symfony/Component/Process/Tests/ProcessBuilderTest.php b/src/Symfony/Component/Process/Tests/ProcessBuilderTest.php
@@ -152,4 +152,29 @@ public function testShouldEscapeArgumentsAndPrefix()
             $this->assertSame("'%prefix%' 'arg'", $proc->getCommandLine());
         }
     }
+
+    /**
+     * @expectedException \Symfony\Component\Process\Exception\LogicException
+     */
+    public function testShouldThrowALogicExceptionIfNoPrefixAndNoArgument()
+    {
+        ProcessBuilder::create()->getProcess();
+    }
+
+    public function testShouldNotThrowALogicExceptionIfNoArgument()
+    {
+        $process = ProcessBuilder::create()
+            ->setPrefix('/usr/bin/php')
+            ->getProcess();
+
+        $this->assertEquals("'/usr/bin/php'", $process->getCommandLine());
+    }
+
+    public function testShouldNotThrowALogicExceptionIfNoPrefix()
+    {
+        $process = ProcessBuilder::create(array('/usr/bin/php'))
+            ->getProcess();
+
+        $this->assertEquals("'/usr/bin/php'", $process->getCommandLine());
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ public function setOption($name, $value)`
`154`	`154`
`155`	`155`	`public function getProcess()`
`156`	`156`	`{`
`157`		`- if (!count($this->arguments)) {`
	`157`	`+ if (!$this->prefix && !count($this->arguments)) {`
`158`	`158`	`throw new LogicException('You must add() command arguments before calling getProcess().');`
`159`	`159`	`}`
`160`	`160`