fix: accept v20 SSL specific error for alpn selection in http/2

mcollina · mcollina · commit c2c8fd55b778 · 2025-03-19T16:13:47.000+01:00
Signed-off-by: Matteo Collina &lt;hello@matteocollina.com&gt;
diff --git a/test/http2.js b/test/http2.js
@@ -402,11 +402,16 @@ test(
         }
       })
     } catch (error) {
-      t.equal(
-        error.message,
-        'Client network socket disconnected before secure TLS connection was established'
+      t.ok(
+        error.message === 'Client network socket disconnected before secure TLS connection was established' ||
+        error.message.includes('SSL routines:ssl3_read_bytes:tlsv1 alert no application protocol'),
+        `Error message should be as expected: ${error.message}`
+      )
+      t.ok(
+        error.code === 'ECONNRESET' ||
+        error.code === 'ERR_SSL_TLSV1_ALERT_NO_APPLICATION_PROTOCOL',
+        `Error code should be as expected: ${error.code}`
       )
-      t.equal(error.code, 'ECONNRESET')
     }
   }
 )

Original file line number	Diff line number	Diff line change
`@@ -402,11 +402,16 @@ test(`
`402`	`402`	`}`
`403`	`403`	`})`
`404`	`404`	`} catch (error) {`
`405`		`- t.equal(`
`406`		`- error.message,`
`407`		`- 'Client network socket disconnected before secure TLS connection was established'`
	`405`	`+ t.ok(`
	`406`	`+ error.message === 'Client network socket disconnected before secure TLS connection was established' \|\|`
	`407`	`+ error.message.includes('SSL routines:ssl3_read_bytes:tlsv1 alert no application protocol'),`
	`408`	+ `Error message should be as expected: ${error.message}`
	`409`	`+ )`
	`410`	`+ t.ok(`
	`411`	`+ error.code === 'ECONNRESET' \|\|`
	`412`	`+ error.code === 'ERR_SSL_TLSV1_ALERT_NO_APPLICATION_PROTOCOL',`
	`413`	+ `Error code should be as expected: ${error.code}`
`408`	`414`	`)`
`409`		`- t.equal(error.code, 'ECONNRESET')`
`410`	`415`	`}`
`411`	`416`	`}`
`412`	`417`	`)`