10000 fix: interceptors.d.ts has no default export (#3332) · nodejs/undici@a7441d8 · GitHub
[go: up one dir, main page]
Skip to content

Commit a7441d8

Browse files
UzlopakUzlopak
authored
fix: interceptors.d.ts has no default export (#3332)
* fix: types interceptors default export * test for bugs in typescript
1 parent 5dadb95 commit a7441d8

File tree

6 files changed

+16
-21
lines changed

6 files changed

+16
-21
lines changed

‎package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585
"test:node-test": "borp -p \"test/node-test/**/*.js\"",
8686
"test:tdd": "borp --expose-gc -p \"test/*.js\"",
8787
"test:tdd:node-test": "borp -p \"test/node-test/**/*.js\" -w",
88-
"test:typescript": "tsd && tsc --skipLibCheck test/imports/undici-import.ts",
88+
"test:typescript": "tsd && tsc test/imports/undici-import.ts --typeRoots ./types && tsc ./types/*.d.ts --noEmit --typeRoots ./types",
8989
"test:webidl": "borp -p \"test/webidl/*.js\"",
9090
"test:websocket": "borp -p \"test/websocket/*.js\"",
9191
"test:websocket:autobahn": "node test/autobahn/client.js",

‎types/formdata.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
/// <reference types="node" />
33

44
import { File } from './file'
5-
import { SpecIterator, SpecIterableIterator } from './fetch'
5+
import { SpecIterableIterator } from './fetch'
66

77
/**
88
* A `string` or `File` that represents a single value from a set of `FormData` key-value pairs.

‎types/index.d.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ declare namespace Undici {
4242
var RedirectHandler: typeof import ('./handlers').RedirectHandler
4343
var DecoratorHandler: typeof import ('./handlers').DecoratorHandler
4444
var RetryHandler: typeof import ('./retry-handler').default
45-
var createRedirectInterceptor: typeof import ('./interceptors').createRedirectInterceptor
45+
var createRedirectInterceptor: typeof import ('./interceptors').default.createRedirectInterceptor
4646
var BalancedPool: typeof import('./balanced-pool').default;
4747
var Client: typeof import('./client').default;
4848
var buildConnector: typeof import('./connector').default;
@@ -67,9 +67,5 @@ declare namespace Undici {
6767
var File: typeof import('./file').File;
6868
var FileReader: typeof import('./filereader').FileReader;
6969
var caches: typeof import('./cache').caches;
70-
var interceptors: {
71-
dump: typeof import('./interceptors').dump;
72-
retry: typeof import('./interceptors').retry;
73-
redirect: typeof import('./interceptors').redirect;
74-
}
70+
var interceptors: typeof import('./interceptors').default;
7571
}

‎types/interceptors.d.ts

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,15 @@
11
import Dispatcher from "./dispatcher";
22
import RetryHandler from "./retry-handler";
33

4-
export type DumpInterceptorOpts = { maxSize?: number }
5-
export type RetryInterceptorOpts = RetryHandler.RetryOptions
6-
export type RedirectInterceptorOpts = { maxRedirections?: number }
4+
export default Interceptors;
75

8-
export declare function createRedirectInterceptor (opts: RedirectInterceptorOpts): Dispatcher.DispatcherComposeInterceptor
9-
export declare function dump(opts?: DumpInterceptorOpts): Dispatcher.DispatcherComposeInterceptor
10-
export declare function retry(opts?: RetryInterceptorOpts): Dispatcher.DispatcherComposeInterceptor
11-
export declare function redirect(opts?: RedirectInterceptorOpts): Dispatcher.DispatcherComposeInterceptor
6+
declare namespace Interceptors {
7+
export type DumpInterceptorOpts = { maxSize?: number }
8+
export type RetryInterceptorOpts = RetryHandler.RetryOptions
9+
export type RedirectInterceptorOpts = { maxRedirections?: number }
10+
11+
export function createRedirectInterceptor(opts: RedirectInterceptorOpts): Dispatcher.DispatcherComposeInterceptor
12+
export function dump(opts?: DumpInterceptorOpts): Dispatcher.DispatcherComposeInterceptor
13+
export function retry(opts?: RetryInterceptorOpts): Dispatcher.DispatcherComposeInterceptor
14+
export function redirect(opts?: RedirectInterceptorOpts): Dispatcher.DispatcherComposeInterceptor
15+
}

‎types/retry-agent.d.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
1-
import Agent from './agent'
2-
import buildConnector from './connector';
31
import Dispatcher from './dispatcher'
4-
import { IncomingHttpHeaders } from './header'
52
import RetryHandler from './retry-handler'
63

74
export default RetryAgent

‎types/webidl.d.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,7 @@ interface WebidlUtil {
5555
V: unknown,
5656
bitLength: number,
5757
signedness: 'signed' | 'unsigned',
58-
opts?: ConvertToIntOpts,
59-
prefix: string,
60-
argument: string
58+
opts?: ConvertToIntOpts
6159
): number
6260

6361
/**

0 commit comments

Comments
 (0)
0