From 6006055592fa8123054ade7a2c92261c626e37a1 Mon Sep 17 00:00:00 2001 From: Robert Nagy Date: Tue, 2 Sep 2025 09:42:17 +0200 Subject: [PATCH 1/2] http: use cached '1.1' http version string --- lib/_http_common.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/_http_common.js b/lib/_http_common.js index 96d9bdfc9fcbe5..28326c7ef18967 100644 --- a/lib/_http_common.js +++ b/lib/_http_common.js @@ -64,6 +64,8 @@ function parserOnHeaders(headers, url) { this._url += url; } +const HTTP_VERSION_1_1 = '1.1'; + // `headers` and `url` are set only if .onHeaders() has not been called for // this request. // `url` is not set for response parsers but that's not applicable here since @@ -91,7 +93,9 @@ function parserOnHeadersComplete(versionMajor, versionMinor, headers, method, const incoming = parser.incoming = new ParserIncomingMessage(socket); incoming.httpVersionMajor = versionMajor; incoming.httpVersionMinor = versionMinor; - incoming.httpVersion = `${versionMajor}.${versionMinor}`; + incoming.httpVersion = versionMajor === 1 && versionMinor === 1 + ? HTTP_VERSION_1_1 + : `${versionMajor}.${versionMinor}`; incoming.joinDuplicateHeaders = socket?.server?.joinDuplicateHeaders || parser.joinDuplicateHeaders; incoming.url = url; From f3be553a71c1ebbdb6708533864f2adacd744810 Mon Sep 17 00:00:00 2001 From: Robert Nagy Date: Tue, 2 Sep 2025 20:53:18 +0200 Subject: [PATCH 2/2] Update lib/_http_common.js Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> --- lib/_http_common.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/_http_common.js b/lib/_http_common.js index 28326c7ef18967..1278a0a0903c65 100644 --- a/lib/_http_common.js +++ b/lib/_http_common.js @@ -93,9 +93,9 @@ function parserOnHeadersComplete(versionMajor, versionMinor, headers, method, const incoming = parser.incoming = new ParserIncomingMessage(socket); incoming.httpVersionMajor = versionMajor; incoming.httpVersionMinor = versionMinor; - incoming.httpVersion = versionMajor === 1 && versionMinor === 1 - ? HTTP_VERSION_1_1 - : `${versionMajor}.${versionMinor}`; + incoming.httpVersion = versionMajor === 1 && versionMinor === 1 ? + HTTP_VERSION_1_1 : + `${versionMajor}.${versionMinor}`; incoming.joinDuplicateHeaders = socket?.server?.joinDuplicateHeaders || parser.joinDuplicateHeaders; incoming.url = url;