-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Closed
Labels
v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.
Description
- Version: Node 10.0.0
- Platform: Debian GNU/Linux 8.10 (jessie)
Node 10.0.0 yields an unexpected result when functions are converted to strings through the toString method. Here's what happens:
- 10.0.0:
(function () { }).toString()results in:'function () { }'. - 9.5.0:
(function(){ }).toString()results in:'function (){ }'.
This difference seems insignificant, but it affects several critical NPM modules. One example is: promisify-node, here's a relevant issue that I created in that repo: nodegit/promisify-node#28
Of course, this means that many other NPM repos are being affected, such as: nodegit. Here's the issue I created for them: nodegit/nodegit#1490
Within the other affected modules, we have: nodegit-promise, asap, fbjs, eslint-plugin-react, and so on and so forth.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.