build: use npm ci

refack · targos · commit fc1259bf5674 · 2018-09-03T17:56:23.000+02:00
* remove obsolete `node_modules/js-yaml/package.json` target * remove `@touch` since `npm ci` is always destructive PR-URL: #22399 Refs: #21802 Refs: #21490 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Sam Ruby <rubys@intertwingly.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
diff --git a/Makefile b/Makefile
@@ -642,12 +642,8 @@ out/doc/api/assets/%: doc/api_assets/% out/doc/api/assets
 	@cp $< $@
 
 
-run-npm-install = $(PWD)/$(NPM) install --production --no-package-lock
 run-npm-ci = $(PWD)/$(NPM) ci
 
-tools/doc/node_modules/js-yaml/package.json:
-	cd tools/doc && $(call available-node,$(run-npm-install))
-
 gen-api = tools/doc/generate.js --node-version=$(FULLVERSION) \
 		--analytics=$(DOCS_ANALYTICS) $< --output-directory=out/doc/api
 
@@ -1074,8 +1070,7 @@ lint-md-build: tools/remark-cli/node_modules \
 
 tools/doc/node_modules: tools/doc/package.json
 ifeq ($(node_use_openssl),true)
-	cd tools/doc && $(call available-node,$(run-npm-install))
-	@touch $@
+	cd tools/doc && $(call available-node,$(run-npm-ci))
 else
 	@echo "Skipping tools/doc/node_modules (no crypto)"
 endif
@@ -1184,7 +1179,7 @@ LINT_CPP_FILES = $(filter-out $(LINT_CPP_EXCLUDE), $(wildcard \
 ADDON_DOC_LINT_FLAGS=-whitespace/ending_newline,-build/header_guard
 
 format-cpp-build:
-	cd tools/clang-format && $(call available-node,$(run-npm-install))
+	cd tools/clang-format && $(call available-node,$(run-npm-ci))
 
 format-cpp-clean:
 	$(RM) -r tools/clang-format/node_modules
diff --git a/vcbuild.bat b/vcbuild.bat
@@ -439,7 +439,7 @@ if not defined doc (
 if exist "tools\doc\node_modules\unified\package.json" goto skip-install-doctools
 SETLOCAL
 cd tools\doc
-%npm_exe% install
+%npm_exe% ci
 cd ..\..
 if errorlevel 1 goto exit
 ENDLOCAL
