test: use PYTHON executable from env in assertSnapshot

aduh95 · marco-ippolito · commit edb75aebd7cc · 2024-08-19T10:32:43.000+02:00
PR-URL: #53938 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
diff --git a/test/common/assertSnapshot.js b/test/common/assertSnapshot.js
@@ -78,8 +78,11 @@ async function spawnAndAssert(filename, transform = (x) => x, { tty = false, ...
     return;
   }
   const flags = common.parseTestFlags(filename);
-  const executable = tty ? path.join(__dirname, '../..', 'tools/pseudo-tty.py') : process.execPath;
-  const args = tty ? [process.execPath, ...flags, filename] : [...flags, filename];
+  const executable = tty ? (process.env.PYTHON || 'python3') : process.execPath;
+  const args =
+    tty ?
+      [path.join(__dirname, '../..', 'tools/pseudo-tty.py'), process.execPath, ...flags, filename] :
+      [...flags, filename];
   const { stdout, stderr } = await common.spawnPromisified(executable, args, options);
   await assertSnapshot(transform(`${stdout}${stderr}`), filename);
 }

Original file line number	Diff line number	Diff line change
`@@ -78,8 +78,11 @@ async function spawnAndAssert(filename, transform = (x) => x, { tty = false, ...`
`78`	`78`	`return;`
`79`	`79`	`}`
`80`	`80`	`const flags = common.parseTestFlags(filename);`
`81`		`- const executable = tty ? path.join(__dirname, '../..', 'tools/pseudo-tty.py') : process.execPath;`
`82`		`- const args = tty ? [process.execPath, ...flags, filename] : [...flags, filename];`
	`81`	`+ const executable = tty ? (process.env.PYTHON \|\| 'python3') : process.execPath;`
	`82`	`+ const args =`
	`83`	`+ tty ?`
	`84`	`+ [path.join(__dirname, '../..', 'tools/pseudo-tty.py'), process.execPath, ...flags, filename] :`
	`85`	`+ [...flags, filename];`
`83`	`86`	`const { stdout, stderr } = await common.spawnPromisified(executable, args, options);`
`84`	`87`	await assertSnapshot(transform(`${stdout}${stderr}`), filename);
`85`	`88`	`}`