8000 process: set up process warning handler in pre-execution · nodejs/node@cc606e2 · GitHub
[go: up one dir, main page]
Skip to content

Commit cc606e2

Browse files
joyeecheungtargos
joyeecheung
authored and
targos
committed
process: set up process warning handler in pre-execution
Since it depends on environment variables. Backport-PR-URL: #26662 PR-URL: #26466 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 03dba72 commit cc606e2

File tree

3 files changed

+16
-4
lines changed

3 files changed

+16
-4
lines changed

‎lib/internal/bootstrap/node.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,12 +115,9 @@ if (isMainThread) {
115115
}
116116

117117
const {
118-
onWarning,
119118
emitWarning
120119
} = NativeModule.require('internal/process/warning');
121-
if (!process.noProcessWarnings && process.env.NODE_NO_WARNINGS !== '1') {
122-
process.on('warning', onWarning);
123-
}
120+
124121
process.emitWarning = emitWarning;
125122

126123
const {

‎lib/internal/bootstrap/pre_execution.js‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ let traceEventsAsyncHook;
88
function prepareMainThreadExecution() {
99
setupTraceCategoryState();
1010

11+
setupWarningHandler();
12+
1113
// Only main thread receives signals.
1214
setupSignalHandlers();
1315

@@ -36,6 +38,15 @@ function prepareMainThreadExecution() {
3638
loadPreloadModules();
3739
}
3840

41+
function setupWarningHandler() {
42+
const {
43+
onWarning
44+
} = require('internal/process/warning');
45+
if (!process.noProcessWarnings && process.env.NODE_NO_WARNINGS !== '1') {
46+
process.on('warning', onWarning);
47+
}
48+
}
49+
3950
function initializeReport() {
4051
if (!getOptionValue('--experimental-report')) {
4152
return;
@@ -251,6 +262,7 @@ function loadPreloadModules() {
251262
}
252263

253264
module.exports = {
265+
setupWarningHandler,
254266
prepareMainThreadExecution,
255267
initializeDeprecations,
256268
initializeESMLoader,

‎lib/internal/main/worker_thread.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
// message port.
55

66
const {
7+
setupWarningHandler,
78
initializeDeprecations,
89
initializeESMLoader,
910
initializeFrozenIntrinsics,
@@ -39,6 +40,8 @@ const {
3940
const publicWorker = require('worker_threads');
4041
const debug = require('util').debuglog('worker');
4142

43+
setupWarningHandler();
44+
4245
debug(`[${threadId}] is setting up worker child environment`);
4346

4447
// Set up the message port and start listening

0 commit comments

Comments
 (0)
0